Test necessity of logger replacement before logging #4127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code optimizes thread performance by checking if the logging level is enabled before proceeding with expensive operations. The guard clause in EvolvingLog prevents unnecessary blocking when multiple threads call logging methods that won't actually output anything due to the current log level configuration. This reduces contention on the synchronized updateLog() method when logging is disabled for that level.
|
|
|
Dear @piers-williams |
I've logged the ticket in my queue to look at |
@piers-williams Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code optimizes thread performance by checking if the logging level is enabled before proceeding with expensive operations. The guard clause in EvolvingLog prevents unnecessary blocking when multiple threads call logging methods that won't actually output anything due to the current log level configuration. This reduces contention on the synchronized updateLog() method when logging is disabled for that level.