Gradle: Update Gradle Plugin extension to use properties #3879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the flyway gradle plugin to provide `Property<>` values on the extension rather than using bare types. This is incredibly important for working with Gradle such that properties remain lazy. This allows values to be configured from different locations rather than relying on being available immediately.
|
|
This was referenced Apr 18, 2025
WilliamL-RG
requested changes
May 2, 2025
| public Map<String, String> pluginConfiguration; | ||
| private final MapProperty<String, String> pluginConfiguration; | ||
|
|
||
| FlywayExtension(ObjectFactory objects) { |
There was a problem hiding this comment.
This needs to be made public
| */ | ||
| public class FlywayPlugin implements Plugin<Project> { | ||
| public void apply(Project project) { | ||
| project.getExtensions().create("flyway", FlywayExtension.class); |
There was a problem hiding this comment.
This would need to be updated to match the new constructor
| if (value instanceof Provider<?> && ((Provider<?>) value).isPresent()) { | ||
| config.put(key, ((Provider<?>) value).get().toString()); | ||
| } else { | ||
| config.put(key, value.toString()); |
There was a problem hiding this comment.
This will need a null check to ensure configuration parameters are properly set to null and not an empty string
| * The version to tag an existing schema with when executing baseline. (default: 1) | ||
| */ | ||
| public String baselineVersion; | ||
| private final Property<String> baselineVersion; |
There was a problem hiding this comment.
This can create conflicts with baseline versions that are not written as a string. For example this will not accept baselineVersion = 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the flyway gradle plugin to provide
Property<>values on the extension rather than using bare types. This is incredibly important for working with Gradle such that properties remain lazy. This allows values to be configured from different locations rather than relying on being available immediately.Drive-by: This bumps the version of Gradle from 6.1.1 (Jan 2020) to 6.9.4 (Feb 2023). The version in use is wildly out of date.
All changes within this PR are backwards compatible with Version 6.9.4.