Refactor search functionality#302
Conversation
|
Hello @OliverRhyme, Few things from me,
Thanks for this. |
I am able to run the page on my github fork at https://oliverrhyme.github.io/devs/ |
joshuadeguzman
left a comment
There was a problem hiding this comment.
Hello @OliverRhyme,
Thanks for the PR. 🎉
Kindly review the comments. For the meantime, let's ignore issues that are not related to the PR, eg. providing repository and data source, to keep the PR small as possible.
I've just refactored, as it is needed for the search to work properly |
cd4919f to
f87b877
Compare
|
Separated dev loading indicator into another pull request. Will request another pull request when this is merged to avoid conflict. |
…om jobs page Fix dev page bug where the page is stuck in loading when switching from jobs page
|
Hi po @joshuadeguzman @Jansalvador1445 pa review po. I've already addressed some of the concerns. Note: This will overwrite the #282 since its not compatible, but I have my own implementation with the follow up PR which can easily be improved. |
|
@all-contributors please add @OliverRhyme for code, bug |
|
I've put up a pull request to add @OliverRhyme! 🎉 |

@joshuadeguzman
Refactors the search functionality with the flexibility to easily integrate Jobs search.
Edit:
Add Developer loading