fix(connectivity_plus): Use serial queue for NWPathMonitor to prevent race condition crash#3752
Open
manuel-goester-n41 wants to merge 1 commit intofluttercommunity:mainfrom
Conversation
… race condition crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a crash occurring on iOS/macOS when
NWPathMonitorupdates are processed concurrently while the monitor is being deallocated.The crash manifests as
swift::fatalError/swift_deallocPartialClassInstance/ double free.The
NWPathMonitorwas previously initialized on a global concurrent queue (DispatchQueue.global(qos: .utility)). This allowed race conditions where thepathUpdateHandlerblock could still be executing on one thread whilestop()was settingpathMonitor = nilon another, leading to memory corruption.Fix: Changed the queue to a private serial
DispatchQueue. This ensures that start, stop, and update events are processed sequentially, preventing the race condition.Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).