Run gradient e2e benchmarks on Windows CI - #191024
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds three new Windows gradient performance end-to-end tests to the CI configuration, TESTOWNERS, and devicelab tasks, and updates the test creation functions in perf_tests.dart to accept a createPlatforms parameter. The review feedback requests adding documentation comments to these updated public functions, in accordance with the style guide.
| } | ||
|
|
||
| TaskFunction createGradientDynamicPerfE2ETest() { | ||
| TaskFunction createGradientDynamicPerfE2ETest({List<String> createPlatforms = const <String>[]}) { |
There was a problem hiding this comment.
According to the Flutter Style Guide, all public members should have documentation. Please add a documentation comment (using ///) to createGradientDynamicPerfE2ETest.
| TaskFunction createGradientDynamicPerfE2ETest({List<String> createPlatforms = const <String>[]}) { | |
| /// Creates a task that runs the gradient dynamic performance end-to-end test. | |
| TaskFunction createGradientDynamicPerfE2ETest({List<String> createPlatforms = const <String>[]}) { |
References
- All public members should have documentation. (link)
| TaskFunction createGradientConsistentPerfE2ETest({ | ||
| List<String> createPlatforms = const <String>[], | ||
| }) { |
There was a problem hiding this comment.
According to the Flutter Style Guide, all public members should have documentation. Please add a documentation comment (using ///) to createGradientConsistentPerfE2ETest.
| TaskFunction createGradientConsistentPerfE2ETest({ | |
| List<String> createPlatforms = const <String>[], | |
| }) { | |
| /// Creates a task that runs the gradient consistent performance end-to-end test. | |
| TaskFunction createGradientConsistentPerfE2ETest({ | |
| List<String> createPlatforms = const <String>[], | |
| }) { |
References
- All public members should have documentation. (link)
| } | ||
|
|
||
| TaskFunction createGradientStaticPerfE2ETest() { | ||
| TaskFunction createGradientStaticPerfE2ETest({List<String> createPlatforms = const <String>[]}) { |
There was a problem hiding this comment.
According to the Flutter Style Guide, all public members should have documentation. Please add a documentation comment (using ///) to createGradientStaticPerfE2ETest.
| TaskFunction createGradientStaticPerfE2ETest({List<String> createPlatforms = const <String>[]}) { | |
| /// Creates a task that runs the gradient static performance end-to-end test. | |
| TaskFunction createGradientStaticPerfE2ETest({List<String> createPlatforms = const <String>[]}) { |
References
- All public members should have documentation. (link)
1 participant
Related: #190401
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.