Add await or ignore to future-returning methods defined in Dart SDK#184229
Add await or ignore to future-returning methods defined in Dart SDK#184229victorsanni wants to merge 4 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
a: tests
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses unawaited futures across various packages and tests by adding await to asynchronous calls—such as close, spawn, and runZoned—or applying // ignore: unawaited_futures where intentional. It also refactors file creation in snippets_test.dart and adds a new test case for ID matching in vm_service_golden_client_test.dart. Feedback suggests using asynchronous writeAsString instead of writeAsStringSync in snippets_test.dart to maintain consistency with the async test environment.
| ..writeAsStringSync(''' | ||
| final File exampleFile = memoryFileSystem.file(examplePath); | ||
| await exampleFile.create(recursive: true); | ||
| exampleFile.writeAsStringSync(''' |
There was a problem hiding this comment.
For consistency with the async nature of this test and to avoid blocking, consider using the asynchronous writeAsString method instead of writeAsStringSync.
| exampleFile.writeAsStringSync(''' | |
| await exampleFile.writeAsString(''' |
| ..writeAsStringSync(''' | ||
| final File exampleFile = memoryFileSystem.file(examplePath); | ||
| await exampleFile.create(recursive: true); | ||
| exampleFile.writeAsStringSync(''' |
There was a problem hiding this comment.
For consistency with the async nature of this test and to avoid blocking, consider using the asynchronous writeAsString method instead of writeAsStringSync.
| exampleFile.writeAsStringSync(''' | |
| await exampleFile.writeAsString(''' |
1 participant
Part of #181513