Make sure that an AnimatedGrid doesn't crash in 0x0 environment #180159
Conversation
github-actions
bot
added
the
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure that AnimatedGrid does not crash when rendered in a zero-sized environment. My review points out that the test may not be correctly targeting the scenario described in the associated issue, as it uses a different grid delegate. I've suggested a change to align the test with the original problem.
| child: AnimatedGrid( | ||
| controller: controller, | ||
| itemBuilder: (_, int index, _) => Text('$index'), | ||
| gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(crossAxisCount: 2), |
There was a problem hiding this comment.
The issue this PR aims to fix is specific to SliverGridDelegateWithMaxCrossAxisExtent, which can compute a crossAxisCount of 0 when the available crossAxisExtent is 0, leading to a division by zero. This test uses SliverGridDelegateWithFixedCrossAxisCount, which has a fixed crossAxisCount and doesn't trigger the bug. To properly test the fix, you should use SliverGridDelegateWithMaxCrossAxisExtent.
| gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(crossAxisCount: 2), | |
| gridDelegate: const SliverGridDelegateWithMaxCrossAxisExtent(maxCrossAxisExtent: 150.0), |
1 participant
This is my attempt to handle #6537 for the AnimatedGrid widget.