Skip to content

CI backports to main#2900

Merged
jnyrup merged 9 commits intofluentassertions:mainfrom
jnyrup:yaml_backports
Dec 20, 2024
Merged

CI backports to main#2900
jnyrup merged 9 commits intofluentassertions:mainfrom
jnyrup:yaml_backports

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Dec 19, 2024 •
edited
Loading

I noticed that #2853 fails to run mac pipeline due to
image

This PR backports changes from develop to main to get a clean CI again.

Resolves all warnings from latest CI run on main.
image

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

dependabot bot and others added 9 commits December 19, 2024 11:50
@dependabot @jnyrup
Bump actions/checkout from 3 to 4 (fluentassertions#2333)
45402c5 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ITaluone @jnyrup
Remove .NET Core 2.1.x and 3.1.x from build SDK setup (fluentassertio…
23d23cb 
…ns#2467)
@vbreuss @jnyrup
Run tests under .NET 8 (fluentassertions#2466)
9d53546
@dependabot @jnyrup
Bump actions/setup-dotnet from 3 to 4
6febbd5 
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 3 to 4.
- [Release notes](https://github.com/actions/setup-dotnet/releases)
- [Commits](actions/setup-dotnet@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-dotnet
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @jnyrup
Bump actions/upload-artifact from 3 to 4
b69759e 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @jnyrup
Bump andstor/file-existence-action from 2 to 3
90e5a7c 
Bumps [andstor/file-existence-action](https://github.com/andstor/file-existence-action) from 2 to 3.
- [Release notes](https://github.com/andstor/file-existence-action/releases)
- [Commits](andstor/file-existence-action@v2...v3)

---
updated-dependencies:
- dependency-name: andstor/file-existence-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@IT-VBFK @jnyrup
Bump macOS/ubuntu version for tests (fluentassertions#2777)
90bfc71 
* Bump macOS version for tests

* Bump ubuntu version
@jnyrup
System.Collections is not needed since net472
cd4e931
@jnyrup
Ignore nuget warnings from MSpec
78e65a8
@coveralls
Copy link

coveralls commented Dec 19, 2024

Pull Request Test Coverage Report for Build 12412242920

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.365%
Totals Coverage Status
Change from base Build 12097079926: 0.0%
Covered Lines: 12933
Relevant Lines: 13169
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Dec 19, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@jnyrup jnyrup requested a review from dennisdoomen December 19, 2024 12:17
@ITaluone
Copy link
Contributor

ITaluone commented Dec 20, 2024

Yeah
Jonas back in business 🎉🎉

@jnyrup jnyrup merged commit 8be39be into fluentassertions:main Dec 20, 2024
5 checks passed
@jnyrup jnyrup deleted the yaml_backports branch December 20, 2024 08:43
@jnyrup jnyrup added the building Building and Infrastructure of Fluent Assertions label Dec 27, 2024
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 20, 2026
Open
Closed
Open
Open
Open
Closed
Open
Closed
Closed
Open
Closed
Open
Merged
Open
Closed
Closed
This was referenced Jan 27, 2026
Merged
Open
Closed
Open
Open
Merged
Open
Open
Open
Merged
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Feb 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

building Building and Infrastructure of Fluent Assertions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jnyrup @coveralls @ITaluone @dennisdoomen @vbreuss @IT-VBFK