Skip to content

Update FluentAssertions package dependencies#2673

Merged
jnyrup merged 4 commits intofluentassertions:developfrom
ViktorHofer:patch-1
Jul 8, 2024
Merged

Update FluentAssertions package dependencies#2673
jnyrup merged 4 commits intofluentassertions:developfrom
ViktorHofer:patch-1

Conversation

@ViktorHofer
Copy link
Contributor

@ViktorHofer ViktorHofer commented Jun 17, 2024 •
edited
Loading

Fixes #2668

Update the ConfigurationManager dependency to 6.0.1 and System.Threading.Tasks.Extensions to 4.5.4.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@ViktorHofer ViktorHofer mentioned this pull request Jun 17, 2024
Closed
@github-actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@ViktorHofer
Copy link
Contributor Author

ViktorHofer commented Jun 17, 2024 •
edited
Loading

Looking at the build failures...

EDIT: Fixed

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9547041476

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.578%
Totals Coverage Status
Change from base Build 9466824578: 0.0%
Covered Lines: 12086
Relevant Lines: 12269
💛 - Coveralls

@dennisdoomen dennisdoomen requested a review from jnyrup June 18, 2024 17:50
@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9565464851

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.578%
Totals Coverage Status
Change from base Build 9466824578: 0.0%
Covered Lines: 12086
Relevant Lines: 12269
💛 - Coveralls

@ViktorHofer
Copy link
Contributor Author

ViktorHofer commented Jul 1, 2024

Hello @dennisdoomen, any update on when we can get this PR merged?

@ITaluone
Copy link
Contributor

ITaluone commented Jul 2, 2024

It is waiting for @jnyrup's review.. As it seems, he is very busy these days :)

@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9765350892

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 97.712%
Files with Coverage Reduction New Missed Lines %
Src/FluentAssertions/Execution/MessageBuilder.cs 1 96.3%
Totals Coverage Status
Change from base Build 9466824578: 0.1%
Covered Lines: 12088
Relevant Lines: 12262
💛 - Coveralls

@jnyrup jnyrup merged commit 2ce3c5e into fluentassertions:develop Jul 8, 2024
@ViktorHofer ViktorHofer deleted the patch-1 branch July 8, 2024 15:17
@jnyrup jnyrup mentioned this pull request Nov 16, 2024
Closed
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Nov 26, 2024
@ViktorHofer @jnyrup
Update FluentAssertions package dependencies (fluentassertions#2673)
6a91b77
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Nov 29, 2024
@jnyrup
Downgrade ConfigurationManager from 6.0.1 to 6.0.0
62b635e 
fluentassertions#2673 bumped from 4.4.0 -> 6.0.1, but 6.0.0 should be enough.
As a testing nuget we should pick the lowest possible version of a package to avoid that tests use a newer package than what is used in production.
@jnyrup jnyrup mentioned this pull request Nov 29, 2024
Merged
7 tasks
jnyrup added a commit that referenced this pull request Nov 30, 2024
@jnyrup
Downgrade ConfigurationManager from 6.0.1 to 6.0.0
0ac7a58 
#2673 bumped from 4.4.0 -> 6.0.1, but 6.0.0 should be enough.
As a testing nuget we should pick the lowest possible version of a package to avoid that tests use a newer package than what is used in production.
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Nov 30, 2024
@ViktorHofer @jnyrup
Update FluentAssertions package dependencies (fluentassertions#2673)
fb60c17
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Nov 30, 2024
@jnyrup
Downgrade ConfigurationManager from 6.0.1 to 6.0.0
8bf44c0 
fluentassertions#2673 bumped from 4.4.0 -> 6.0.1, but 6.0.0 should be enough.
As a testing nuget we should pick the lowest possible version of a package to avoid that tests use a newer package than what is used in production.
@jnyrup jnyrup mentioned this pull request Nov 30, 2024
Merged
7 tasks
jnyrup pushed a commit that referenced this pull request Nov 30, 2024
@ViktorHofer @jnyrup
Update FluentAssertions package dependencies (#2673)
ba3884e
jnyrup added a commit that referenced this pull request Nov 30, 2024
@jnyrup
Downgrade ConfigurationManager from 6.0.1 to 6.0.0
5cdaa07 
#2673 bumped from 4.4.0 -> 6.0.1, but 6.0.0 should be enough.
As a testing nuget we should pick the lowest possible version of a package to avoid that tests use a newer package than what is used in production.
@jnyrup jnyrup added the dependencies Pull requests that update a dependency file label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

+3 more reviewers

@ITaluone ITaluone ITaluone left review comments

@lg2de lg2de lg2de left review comments

@IT-VBFK IT-VBFK IT-VBFK left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Consider updating the ConfigurationManager transitive dependency version

7 participants

@ViktorHofer @coveralls @ITaluone @dennisdoomen @jnyrup @lg2de @IT-VBFK