Drop support for .NET Core#2302
Merged
dennisdoomen merged 1 commit intofluentassertions:developfrom Sep 20, 2023
Merged
Conversation
0c496fc to
a160c43
Compare
Qodana for .NET29 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 6231864167
💛 - Coveralls |
a160c43 to
d62bacf
Compare
Closed
ddaa58f to
99c31e7
Compare
99c31e7 to
6f4076e
Compare
jnyrup
reviewed
Sep 17, 2023
Src/FluentAssertions/Common/MemberPathSegmentEqualityComparer.cs
Outdated
Show resolved
Hide resolved
6f4076e to
a5fba36
Compare
IT-VBFK
reviewed
Sep 18, 2023
Tests/FluentAssertions.Specs/Collections/CollectionAssertionSpecs.BeEquivalentTo.cs
Outdated
Show resolved
Hide resolved
IT-VBFK
reviewed
Sep 18, 2023
a5fba36 to
6b69fd7
Compare
jnyrup
reviewed
Sep 18, 2023
Tests/FluentAssertions.Specs/Collections/CollectionAssertionSpecs.BeEquivalentTo.cs
Outdated
Show resolved
Hide resolved
jnyrup
reviewed
Sep 18, 2023
Tests/FluentAssertions.Specs/Collections/CollectionAssertionSpecs.BeEquivalentTo.cs
Outdated
Show resolved
Hide resolved
6b69fd7 to
392c9e7
Compare
392c9e7 to
f72da25
Compare
Member
Author
|
I'm confused about the Qodana issues. They seem to be false positives. |
jnyrup
approved these changes
Sep 19, 2023
Comment on lines
44
to
49
| Because of that Fluent Assertions supports the following minimum platforms. | ||
|
|
||
| * .NET Core 2.1 and 3.0 | ||
| * .NET Framework 4.7 and later | ||
| * .NET 6.0 and later | ||
| * Mono 5.4, Xamarin.iOS 10.14, Xamarin.Mac 3.8 and Xamarin.Android 8.0 | ||
| * Universal Windows Platform 10.0.16299 and later |
Member
There was a problem hiding this comment.
🙃 We can still run on .NET Core 2.0 and above
"Because of that Fluent Assertions can run on the following minimum platforms."
Member
Which ones? |
Member
Author
This was referenced Jan 20, 2026
This was referenced Jan 27, 2026
Bump FluentAssertions from 7.0.0 to 8.8.0
ks-no/fiks-maskinporten-client-dotnet-integration-tests#17
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given we don't want to shrink the API surface for frameworks supported by Microsoft, this PR reduces the supported frameworks to .NET Framework 4.7, .NET 6.0, .NET Standard 2.0 (because of UWP) and .NET Standard (because of Mono, Xamarin and Unity).
We also decided to no longer test .NET Standard. The biggest risk is that we use something that compiles but doesn't work in Unity, UWP and such. Testing this with other frameworks like the unsupported .NET Core isn't going to help. We could have embraced Unity, UWP and such. But that would require quite some infrastructure, not just for us, but also for our contributors.
Closes #2251
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome