Skip to content

Removed binary formatter#2278

Merged
jnyrup merged 3 commits intofluentassertions:developfrom
lg2de:disable-binary-formatter
Oct 8, 2023
Merged

Removed binary formatter#2278
jnyrup merged 3 commits intofluentassertions:developfrom
lg2de:disable-binary-formatter

Conversation

@lg2de
Copy link
Contributor

@lg2de lg2de commented Aug 23, 2023 •
edited
Loading

This fixes #1779.

The BinaryFormatter is deprecated. So, it will not get part of the planned net8 target.
For all other targets it has been marked as obsolete, which is a breaking change.
After disussion in the linked issue, the support is finally removed completely.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Aug 23, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Aug 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6396364562

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.3%
Totals Coverage Status
Change from base Build 6384600328: 0.0%
Covered Lines: 11594
Relevant Lines: 11796
💛 - Coveralls

@dennisdoomen
Copy link
Member

dennisdoomen commented Aug 23, 2023

I thought we wanted to completely get rid of it, right @jnyrup

Corniel
Corniel approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@Corniel Corniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lg2de
Copy link
Contributor Author

lg2de commented Aug 24, 2023

I thought we wanted to completely get rid of it, right @jnyrup

From BinaryFormatter Obsoletion Strategy:
Applications which target .NET Framework 2.x, .NET Framework 4.x, or .NET Core 3.1 are not affected by this proposal. BinaryFormatter will continue to work as expected in those applications.

So, why removing code for supported targets?

@dennisdoomen dennisdoomen requested a review from jnyrup August 25, 2023 06:46
@lg2de lg2de force-pushed the disable-binary-formatter branch from 4906a14 to 4fa6185 Compare October 3, 2023 17:25
@lg2de lg2de changed the title Disable binary formatter in net8 and make it obsolete otherwise Removed binary formatter Oct 3, 2023
jnyrup
jnyrup reviewed Oct 4, 2023
View reviewed changes
@lg2de lg2de force-pushed the disable-binary-formatter branch from 4fa6185 to 0b7424e Compare October 5, 2023 17:33
@lg2de lg2de force-pushed the disable-binary-formatter branch from 0b7424e to 3a41275 Compare October 5, 2023 17:36
@jnyrup jnyrup merged commit 6f1035a into fluentassertions:develop Oct 8, 2023
@jnyrup jnyrup mentioned this pull request Oct 8, 2023
Merged
7 tasks
@lg2de lg2de deleted the disable-binary-formatter branch October 9, 2023 07:10
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 19, 2026
Open
Open
Open
Open
Closed
Open
Open
Open
Closed
Open
Closed
Closed
Closed
This was referenced Jan 26, 2026
Merged
Open
Closed
Merged
Open
Closed
Open
Open
Merged
Open
Open
Open
Open
Open
This was referenced Feb 2, 2026
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

+1 more reviewer

@Corniel Corniel Corniel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Removal of BinaryFormatter in .NET 8.0

5 participants

@lg2de @coveralls @dennisdoomen @jnyrup @Corniel