Skip to content

Move DataSet/DataTable/DataRow assertions to separate library #2002

@ericnewton76

Description

@ericnewton76

Should DataSet/DataTable/DataRow assertions get lumped into a separate library? These are types that are over 20 years old, introduced with NetFramework 1.0 beta 1... and I know this because yes I was porting things from VB6 back then as fast as I could... ;-D

Of note, starting a fresh testing project with nunit 3.12 and fluentassertions 6.7.0, I get reference errors about missing reference to System.Data v4.0.0. Otherwise FluentAssertions is pretty clean.

  • FluentAssertions 6.7.0
  • Copy all data-related code to https://github.com/fluentassertions/fluentassertions.datasets
  • How can the data project inject additional equivalency steps?
  • Delete all data-related code from the main repo
  • Move the data-related docs to the read-me of the data repo
  • Ensure that the data repo has its own discussions, issues and releases
  • Update the breaking changes of the main repo
  • Push an alpha version of FA 7.0 and update dependencies in the data set project to make it build again
  • Introduce a mechanism for an extension library like FluentAssertions.DataSets to register custom equivalency steps
  • Review all namespace imports and make sure everything works as expected
  • Ensure the build works correctly
  • Identify any code analysis issues
  • Check package contents
  • Update the readme
  • Setup branch protection rules

Metadata

Metadata

Assignees

Type

No type

Projects

Status

✅ Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions