Fix i18n component using wrong translations when inside slot #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demivan
added
Type: Bug
Demivan
force-pushed
the
fix/980-i18n-slot-context
branch
from
474cec1 to
b34b7a3
Compare
Export Sizefluent-vue
|
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
==========================================
- Coverage 99.54% 98.60% -0.95%
==========================================
Files 12 12
Lines 220 215 -5
Branches 45 46 +1
==========================================
- Hits 219 212 -7
- Misses 0 1 +1
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
wbolster
reviewed
Nov 16, 2025
| const fluent = getContext( | ||
| rootContext, | ||
| // @ts-expect-error This is internal Vue feature added in https://github.com/vuejs/core/commit/11214eedd2699e15106c44927f4d1206b111fbd3 | ||
| instance?.vnode?.ctx /* Vue 3 */ ?? instance?.proxy?.$vnode?.context /* Vue 2 */, |
Contributor
There was a problem hiding this comment.
from vuejs/core@11214ee:
- @internal lexical scope owner instance
this sounds exactly right! good find 👍🏼
wbolster
approved these changes
Nov 16, 2025
Contributor
wbolster
left a comment
wbolster
left a comment
There was a problem hiding this comment.
i gave it a spin and it seems to work perfectly! 🤩
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
i18ncomponent was walking parent component tree to search for component with translations. This behavior is incorrect, but it is hard to get lexical rendering content in Vue.This PR switches to internal Vue API for getting lexical rendering context.
Linked Issues
Fixes #980
Additional context
vuejs/core@11214ee - API used by Vue to solve similar issue with CSS v-bind.
Technically this is a breaking change as this changes
i18ncomponent behavior and changes minimum required Vue 3 version. But I expect that nobody is using current behavior or a 3-year-old Vue 3 version.