chore: improve discovery test assertion and add suggest section

alies-dev · alies-dev · commit 7546dd3ea0ea · 2026-03-09T20:26:45.000+01:00
- Test now verifies discovery works by creating a service via Factory
- Add suggest section for PSR-18 client and PSR-17 factory implementations
diff --git a/composer.json b/composer.json
@@ -50,6 +50,11 @@
             "dev-master": "4.0-dev"
         }
     },
+    "suggest": {
+        "php-http/discovery": "Auto-discover PSR-18 HTTP client and PSR-17 request factory",
+        "symfony/http-client": "PSR-18 HTTP client implementation",
+        "nyholm/psr7": "PSR-17 HTTP factory implementation"
+    },
     "config": {
         "allow-plugins": {
             "php-http/discovery": true
diff --git a/tests/Service/FactoryTest.php b/tests/Service/FactoryTest.php
@@ -102,9 +102,11 @@ public function constructInvalidClient()
     #[Test]
     public function withNullAsClientUsesDiscovery()
     {
+        // php-http/mock-client (dev dep) provides client-implementation,
+        // so PSR-18 discovery succeeds and Factory can create services.
         $factory = new Factory();
 
-        $this->assertInstanceOf(Factory::class, $factory);
+        $this->assertInstanceOf(EuropeanCentralBank::class, $factory->create('european_central_bank'));
     }
 
     #[Test]

Original file line number	Diff line number	Diff line change
`@@ -102,9 +102,11 @@ public function constructInvalidClient()`
`102`	`102`	`#[Test]`
`103`	`103`	`public function withNullAsClientUsesDiscovery()`
`104`	`104`	`{`
	`105`	`+ // php-http/mock-client (dev dep) provides client-implementation,`
	`106`	`+ // so PSR-18 discovery succeeds and Factory can create services.`
`105`	`107`	`$factory = new Factory();`
`106`	`108`
`107`		`- $this->assertInstanceOf(Factory::class, $factory);`
	`109`	`+ $this->assertInstanceOf(EuropeanCentralBank::class, $factory->create('european_central_bank'));`
`108`	`110`	`}`
`109`	`111`
`110`	`112`	`#[Test]`