fix(FloatingPortal): fix non-modal dialog accessibility with iOS/Safari/Voice Control #3408
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02fb7ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for vibrant-gates-22c214 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@floating-ui/core
@floating-ui/dom
@floating-ui/react
@floating-ui/react-dom
@floating-ui/react-native
@floating-ui/utils
@floating-ui/vue
commit: |
mihkeleidast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3403.
Changes the hidden styles implementation to use very minimal set of styles on the owner element so iOS Voice Control works OK after this change. I think the rest of visually hidden styles should not be needed, as most of it deals with hiding content, which the
aria-ownselement does not have. But let me know if you find a scenario where this breaks layout or something.For reference: https://www.tpgi.com/the-anatomy-of-visually-hidden/
I've tested it here with the canary release version: https://codesandbox.io/p/sandbox/brave-snowflake-qc7myq