Add test for empty metadata, and the null byte.

brian-brazil · brian-brazil · commit c8c5a027668a · 2018-10-03T14:14:13.000+01:00
Signed-off-by: Brian Brazil &lt;brian.brazil@robustperception.io&gt;
diff --git a/tests/openmetrics/test_parser.py b/tests/openmetrics/test_parser.py
@@ -173,6 +173,14 @@ def test_no_metadata(self):
         metric_family.add_sample("a", {}, 1)
         self.assertEqual([metric_family], list(families))
 
+    def test_empty_metadata(self):
+        families = text_string_to_metric_families("""# HELP a 
+# UNIT a 
+# EOF
+""")
+        metric_family = Metric("a", "", "untyped")
+        self.assertEqual([metric_family], list(families))
+
     def test_untyped(self):
         # https://github.com/prometheus/client_python/issues/79
         families = text_string_to_metric_families("""# HELP redis_connected_clients Redis connected clients
@@ -315,6 +323,14 @@ def test_escaping(self):
         metric_family.add_metric(["b\\a\\z"], 2)
         self.assertEqual([metric_family], list(families))
 
+    def test_null_byte(self):
+        families = text_string_to_metric_families("""# TYPE a counter
+# HELP a he\0lp
+# EOF
+""")
+        metric_family = CounterMetricFamily("a", "he\0lp")
+        self.assertEqual([metric_family], list(families))
+
     def test_timestamps(self):
         families = text_string_to_metric_families("""# TYPE a counter
 # HELP a help
