added json by default functionality for security#7
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces JSON as the default session serialization format (with optional encryption) alongside the existing PHP serialization, plus comprehensive tests for both modes.
- Add
serializationconfig (defaults to'json') with validation - Update
read/writeto branch on JSON vs. PHP and handle encryption - Introduce
assertNoObjectsto prevent unsafe JSON storage and add tests for all modes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Session.php | Add serialization property, enhance read/write, add object guard |
| tests/SessionTest.php | New tests for JSON/PHP serialization (plain & encrypted) and object rejection |
Comments suppressed due to low confidence (2)
src/Session.php:229
- The write-skip condition allows writing when
$this->datais empty but not marked changed, potentially writing empty files. Consider also skipping whenempty($this->data)is true, or revert to the original logic to prevent unintended empty writes.
if ($this->changed !== true && !empty($this->data)) {
src/Session.php:479
assertNoObjects()assumes$datais always iterable. For scalar session values (e.g., integers or strings), this will produce a foreach warning. Guard withis_array($current)before iterating.
foreach ($current as $v) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.