Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances router performance by implementing method-based route grouping to optimize route lookup times. The optimization creates separate arrays grouped by HTTP method, allowing the router to search only relevant routes instead of iterating through all routes.
- Introduces a new
$routesByMethodarray to group routes by HTTP method for faster lookups - Modifies the routing algorithm to check method-specific routes first, then fall back to wildcard routes
- Maintains backward compatibility for existing routing behavior including 405 error handling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| flight/net/Router.php | Implements method-based route grouping with fast-path lookup optimization |
| tests/EngineTest.php | Adds comprehensive tests for route iteration behavior and edge cases |
| tests/performance/index.php | Creates performance testing environment with various route types |
| tests/performance/performance_tests.sh | Provides benchmarking script for measuring routing performance |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just was thinking with AI about how to increase the performance out of Flight. The router class can instead search by method instead of everything. It helps shave off about 5% of execution time if your project is large enough. Otherwise it's negligible.