Repository navigation
[2.x] fix(phpstan): recognize conditional model casts - #4920
Merged
Merged
Conversation
Contributor
Author
|
Thanks a lot for the review and merge! Happy to continue with the next fix when I see the next clear gap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Conditionalextender methodsWhy
Conditionalmoved from direct extender arrays tocallable|string, but thePHPStan resolver still looked only for a direct array on
whenExtensionEnabled(). Valid model casts nested in the current callable APIwere therefore reported as undefined properties.
Fixes #4808
Testing
property.notFoundon unchanged2.xvendor/bin/phpstan analyse -c phpstan.neon --no-progress --error-format=table --memory-limit=2Gcomposer validate --no-check-publish(valid; existing dependency-constraint warnings only)