Use $APPIMAGE for autostart entry when running as AppImage - #4866
Open
someone-ua wants to merge 1 commit into
Open
Use $APPIMAGE for autostart entry when running as AppImage#4866someone-ua wants to merge 1 commit into
someone-ua wants to merge 1 commit into
Conversation
When Flameshot runs as an AppImage, "flameshot" is not on PATH and QCoreApplication::applicationFilePath() points at the temporary squashfs mount, which disappears once the AppImage exits. Use the $APPIMAGE environment variable as the Exec path when set, falling back to "flameshot" otherwise, so the generated autostart .desktop file keeps working after reboot.
Member
|
I understand the code logic and it make sense [1], but I'm not sure if it works. Have you tested this yourself? |
Author
|
Yes, I have tested it. It works. There is now actual path to .AppImage in .desktop file so autostart works correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Flameshot runs as an AppImage, "flameshot" is not on PATH and QCoreApplication::applicationFilePath() points at the temporary squashfs mount, which disappears once the AppImage exits. Use the $APPIMAGE environment variable as the Exec path when set, falling back to "flameshot" otherwise, so the generated autostart .desktop file keeps working after reboot.