add(highlight, complete): suggest/complete cd commands in mkdir && cd chains - #12875
Open
ahhyoushh wants to merge 1 commit into
Open
add(highlight, complete): suggest/complete cd commands in mkdir && cd chains#12875ahhyoushh wants to merge 1 commit into
ahhyoushh wants to merge 1 commit into
Conversation
When a user chains `mkdir foo && cd foo`, the `foo` argument to `cd` was
previously highlighted as an error (since it doesn't exist on disk at the
time of typing), and no autosuggestions or completions were offered.
Specifically:
- `highlight.rs` avoids coloring these pending directories as errors,
using trailing-slash normalized paths for robust matching.
- `complete.rs` correctly offers these pending directories as relative
completion candidates and properly deduplicates them.
- Added `extract_mkdir_args_unescaped` in `parse_util.rs` to keep AST
parsing DRY and avoid duplicate extraction logic.
This uses strictly on-the-line parsing and does not rely on history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user chains
mkdir foo && cd foo, thefooargument tocdwas previously highlighted as an error (since it doesn't exist on disk at the time of typing), and no autosuggestion or completions were offered.Specifically:
highlight.rsavoids coloring these pending directories as errors, using trailing-slash normalized paths for robust matching.complete.rscorrectly offers these pending directories as relative completion candidates and properly deduplicates them.extract_mkdir_args_unescapedinparse_util.rsto keep AST parsing DRY and avoid duplicate extraction logic.This uses strictly on-the-line parsing and does not rely on history.
TODOs
Fixes issue #<issue-number>