Allow $() in command position - #12829
Draft
krobelus wants to merge 3 commits into
Draft
Conversation
We allow "$var" in command position but not "$(somecmd)". The latter is usually not something you'd want to use interactively, because command-specific completions don't work because fish won't expand command substitution until the user presses enter. On the other hand, this can be handy for scripts to be able to inline some local variables (see next commit). Also, it might be useful for pasted commands. Also, the behavior of "$(somecmd)" should be obvious. Allow it. For now, don't allow "()" in command position because it means something else in POSIX-style shells. This patch extends some of our old hacks to string expansion, but existing code paths should be untouched. Closes fish-shell#5575
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We allow "$var" in command position but not "$(somecmd)".
The latter is usually not something you'd want to use interactively, because command-specific completions don't work because fish won't expand command substitution until the user presses enter.
On the other hand, this can be handy for scripts to be able to inline some local variables (see next commit).
Also, it might be useful for pasted commands.
Also, the behavior of "$(somecmd)" should be obvious.
Allow it. For now, don't allow "()" in command position because it
means something else in POSIX-style shells.
This patch extends some of our old hacks to string expansion, but
existing code paths should be untouched.
Closes #5575