Repository navigation
Fix project logo alt text: use project name, remove typo - #771
Open
GuillermoBarreto wants to merge 1 commit into
Open
GuillermoBarreto wants to merge 1 commit into
GuillermoBarreto wants to merge 1 commit into
Conversation
The project card logo images all shared the same generic alt text
('the framework or language that the project is build upon'), which
also contained a typo. Screen readers would announce identical alt text
for every project's logo. This change uses each project's name for the
logo alt text instead, e.g. 'activist.org logo'.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The project card logo images in
src/components/ProjectCard.astroall shared the same generic alt text (the framework or language that the project is build upon), which also contained a typo (buildinstead ofbuilt).Why
Screen readers would announce the exact same (misspelled) alt text for all 150+ project logos, giving no information about which project's logo it is. Using each project's name makes the alt text meaningful per card.
Change
alt={name + " logo"}, e.g. "activist.org logo".No visual change; the
onerrorfallback behavior is untouched.