fix(portal): revoke attested access once the client is gone - #15259
Closed
jamilbk wants to merge 1 commit into
Closed
fix(portal): revoke attested access once the client is gone#15259jamilbk wants to merge 1 commit into
jamilbk wants to merge 1 commit into
Conversation
A policy that requires an attested device checked the attestation only at connect, and the authorization then lived until it expired, days later, whether or not the client was still connected. A worker now deletes such authorizations every 15 minutes when the client has no connection to the portal, so the gateway drops the flow.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
coverage: 73.808% (-0.1%) from 73.927% — fix-unattested-authorizations into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A policy that requires an attested device checked the attestation only when the client connected. The authorization it granted then lived until it expired, which can be days, and the gateway kept serving the flow even after the client had dropped off the portal. So a device that attested once at connect kept its access long after the session that vouched for it was gone.
A worker now runs every 15 minutes and deletes the live authorizations of such policies whose client has no connection to the portal. Attestation is a property of the connection that presented the certificate, so without that connection the authorization has nothing to stand on. The gateway drops the flow on the delete, and a client that reconnects attests again and requests fresh authorizations. Authorizations minted in the last two minutes are left alone, since presence takes a moment to reach every node.
A policy requires attestation when its conditions carry
device_attested is trueor its postures carry afirezone.attested is trueleaf.Related: #15173, #15059