This repository was archived by the owner on Sep 21, 2021. It is now read-only.
Adds remapScopes utility function. #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
commented
Nov 3, 2017
| // Moving to the function bounary (in generated scopes). | ||
| while ( | ||
| foundInMax + 1 < searchIn.length && | ||
| searchIn[foundInMax].type !== "function" |
Contributor
Author
There was a problem hiding this comment.
runtime Scope.type property is not reliable
Contributor
There was a problem hiding this comment.
do we need to fall back on block as well while we fix this?
Contributor
Author
There was a problem hiding this comment.
property reliable after all
jasonLaster
reviewed
Nov 6, 2017
| ({ isLast, result }, scope) => { | ||
| if (isLast) { | ||
| result.push([]); | ||
| } |
Contributor
There was a problem hiding this comment.
chunk is a pretty strange term...
I think i would prefer functionScopes, perhaps we move this into a small helper function:
const functionScopes = rollupFunctionScopes(scopes)| const names = summarizedScopes.reduce( | ||
| (acc, { bindingsNames }) => acc.concat(bindingsNames), | ||
| [] | ||
| ); |
Contributor
There was a problem hiding this comment.
it would be nice to have a small helper function: getBindingNames that can take our function scopes and return a list of names...
const names = getBindingNames(scopeChunk)| // Moving to the function bounary (in generated scopes). | ||
| while ( | ||
| foundInMax + 1 < searchIn.length && | ||
| searchIn[foundInMax].type !== "function" |
Contributor
There was a problem hiding this comment.
do we need to fall back on block as well while we fix this?
| } | ||
|
|
||
| // We found chunk of the function(s) that matches the scopeChunk names. | ||
| result.push({ |
yurydelendik
force-pushed
the
remapScopes
branch
from
db97c93 to
2001349
Compare
nchevobbe
pushed a commit
that referenced
this pull request
Nov 21, 2017
nchevobbe
pushed a commit
that referenced
this pull request
Nov 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: firefox-devtools/debugger#4521
Summary of Changes