This repository was archived by the owner on Jan 11, 2023. It is now read-only.
WIP: Add test to ensure original source and pretty printed outline tab functions match #7116#7118
Closed
akashs09 wants to merge 7 commits intofirefox-devtools:masterfrom
Closed
WIP: Add test to ensure original source and pretty printed outline tab functions match #7116#7118akashs09 wants to merge 7 commits intofirefox-devtools:masterfrom
akashs09 wants to merge 7 commits intofirefox-devtools:masterfrom
Conversation
Please, commit your changes before you merge.
…r orig and pretty)
…r orig and pretty)
Contributor
|
This contains loads of unwanted changes and is on git checkout master
git reset --hard upstream/masterTo create a new branch, do: # git checkout -b {descriptive-branch-name}
git checkout -b outline-testThen make your changes, commit, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4430
deleted comments and old code on these 2 files:
src/components/SecondaryPanes/Breakpoints/Breakpoint.js
src/actions/breakpoints/addBreakpoint.js
Here's the Pull Request Doc
https://firefox-dev.tools/debugger.html/docs/pull-requests.html
Test Plan
Tell us a little a bit about how you tested your patch.
Example test plan:
Here's the Debugger's Testing doc
https://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.
Feel free to improve it!
Screenshots/Videos (OPTIONAL)