This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Add test to ensure original source and pretty printed outline tab functions match#7116
Closed
akashs09 wants to merge 7 commits intofirefox-devtools:masterfrom
Closed
Add test to ensure original source and pretty printed outline tab functions match#7116akashs09 wants to merge 7 commits intofirefox-devtools:masterfrom
akashs09 wants to merge 7 commits intofirefox-devtools:masterfrom
Conversation
Please, commit your changes before you merge.
…r orig and pretty)
…r orig and pretty)
darkwing
reviewed
Oct 19, 2018
| node_modules | ||
| out No newline at end of file | ||
| out | ||
| debugger; |
Contributor
There was a problem hiding this comment.
This would be unsafe; let's move it for now
darkwing
reviewed
Oct 19, 2018
| @@ -20574,7 +20574,413 @@ | |||
| "../../parse5/lib/serializer/serializer_stream.js": 1752, | |||
Contributor
There was a problem hiding this comment.
This file shouldn't be part of the PR.
darkwing
reviewed
Oct 19, 2018
| @@ -1,5 +1,7 @@ | |||
| // MIT © Sindre Sorhus - sindresorhus.com | |||
Contributor
There was a problem hiding this comment.
Not sure what this is for.
darkwing
reviewed
Oct 19, 2018
| "logging": { | ||
| "client": false, | ||
| "firefoxProxy": false, | ||
| "actions": false |
Contributor
There was a problem hiding this comment.
Not sure what this is for.
darkwing
reviewed
Oct 19, 2018
| "logging": { | ||
| "firefoxProxy": false | ||
| "firefoxProxy": false, | ||
| "actions": true |
Contributor
There was a problem hiding this comment.
Not sure what this is for.
darkwing
reviewed
Oct 19, 2018
| { condition, hidden }: addBreakpointOptions = {} | ||
| ) { | ||
| const breakpoint = createBreakpoint(location, { condition, hidden }); | ||
| // debugger; |
darkwing
reviewed
Oct 19, 2018
| * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */ | ||
|
|
||
| /* This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this |
Contributor
There was a problem hiding this comment.
Did this get added twice?
darkwing
reviewed
Oct 19, 2018
| }); | ||
| }); | ||
|
|
||
| describe("Switching to outline tabs with same url", () => { |
Contributor
There was a problem hiding this comment.
This test doesn't do anything and should be removed.
darkwing
reviewed
Oct 19, 2018
| @@ -22,6 +22,11 @@ add_task(async function() { | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This is the only file that should contain changes.
darkwing
reviewed
Oct 19, 2018
| const original_source = getItems(dbg); | ||
| findElementWithSelector(dbg, ".prettyPrint").click(); | ||
| const pretty_source = getItems(dbg); | ||
| is(original_source.length == pretty_source.length, "Outline functions match") |
Contributor
There was a problem hiding this comment.
This needs to be:
is(original_source.length, pretty_source.length, "Outline functions match");
``
Also, JavaScript uses camelcasing, so please use `originalSource`, and `prettySource`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4430
Here's the Pull Request Doc
https://firefox-dev.tools/debugger.html/docs/pull-requests.html
Summary of Changes
Test Plan
Tell us a little a bit about how you tested your patch.
Example test plan:
Here's the Debugger's Testing doc
https://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.
Feel free to improve it!
Screenshots/Videos (OPTIONAL)