This repository was archived by the owner on Jan 11, 2023. It is now read-only.
#4756 Remove stray line#4762
Merged
jasonLaster merged 2 commits intofirefox-devtools:masterfrom Nov 27, 2017
Merged
Conversation
Contributor
|
Hi! Thanks for the pr! A bit of context around this, since I recently merged a pr changing this same line. it used to be 29px, but was changed to 30px because of this bug: #4598 the code is visible under the panel in certain situations. can you check if it also covers the other case? if not when i get a bit more time i will take a look as well! |
Contributor
Author
|
Sure, I will take a look later today ! Thanks for the additional info |
Contributor
|
@cristidrg thanks for taking a look at that! looks good, i will merge once travis agrees! |
AnshulMalik
pushed a commit
to AnshulMalik/debugger.html
that referenced
this pull request
Dec 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #4756
Summary of Changes
Modified header variable to actually match the given value: https://github.com/devtools-html/debugger.html/blob/master/src/components/Editor/Tabs.css#L8
Test Plan
Visual change, looks neat now.
Screenshot
The issue was actually always there, not just in the dark theme. See the picture below:
It was not obvious in the other themes because the background was white.