This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Converted source tree SVG's to images using CSS styles#4461
Closed
jselmani wants to merge 1 commit intofirefox-devtools:masterfrom
jselmani:Issue4350SourceTree
Closed
Converted source tree SVG's to images using CSS styles#4461jselmani wants to merge 1 commit intofirefox-devtools:masterfrom jselmani:Issue4350SourceTree
jselmani wants to merge 1 commit intofirefox-devtools:masterfrom
jselmani:Issue4350SourceTree
Conversation
James300
reviewed
Oct 21, 2017
| .file, | ||
| .folder, | ||
| .domain { | ||
| background-color: var(--theme-splitter-color); |
Contributor
There was a problem hiding this comment.
Out of curiosity, why does this use background-color whereas before it used fill?
Author
There was a problem hiding this comment.
Fill is used to fill in paths of SVG's that are loaded into a webpage whereas background color loads a color into the div.
With a mask being used over the div, the background color is what shows through the mask. Hope that helps @James300
Contributor
There was a problem hiding this comment.
Thank you, that makes a lot of sense 👍
Contributor
|
@jselmani mind sharing a screenshot? |
Author
|
Here they are @jasonLaster Firefox
Chrome
|
Author
|
Closing as new PR (#4477) was made to resolve these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #4350
Description
Converted the Source Tree SVG's to Images using CSS styles. This should have a significant performance improvement for the project as rendering of SVG's is no longer required. Can perhaps also close Issue #4168 should the improvement be significant enough.
In regards to the Webpack SVG, with so many different paths being filled different colours, converting to an image would likely not reflect the same image that is portrayed currently as it will all be one colour if changed.
Screenshots
Webpack SVG
Fill Paths