Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Conversation

@lukaszsobek
Copy link
Contributor

Associated Issue: #3980

Summary of Changes

  • removes comments from pending-breakpoints.js

Test Plan

Visually confirmed they are gone

Copy link
Contributor

@bomsy bomsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukaszsobek
Copy link
Contributor Author

Thanks - husky gave me a bit of trouble with his one, bad dog!

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, while we’re in here would you mind checking to see if the other reducers/actions have the correct documentation?


/**
* Breakpoints reducer
* @module reducers/breakpoints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about we change this to:

- /**
-  * Breakpoints reducer
-  * @module reducers/pendingbreakpoints

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, willl do.

@jasonLaster jasonLaster changed the title - removes comments from pending-breakpoints.js #3980 Removes comments from pending-breakpoints.js #3980 Oct 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants