-
Notifications
You must be signed in to change notification settings - Fork 750
Update travis #4054
Update travis #4054
Conversation
|
Thanks @Fischer-L, I'm adding @darkwing as a reviewer |
3540aa0 to
e1d2904
Compare
e1d2904 to
81b08cb
Compare
@jasonLaster My PR is #4057 so I guess #4057 is what you mean right? Thanks |
|
oops :) |
ochameau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't understood it was working for real, like, in production.
With documentation and scripts to help running them locally.
That's really fantastic!
| global: | ||
| - DISPLAY=':99.0' | ||
| - YARN_VERSION='0.24.5' | ||
| - MC_COMMIT='abd295766dfe' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you now able to bump this m-c changeset easily/frequently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. It's fixed so that we always get a good artifact build though
|
|
||
| cd firefox | ||
| hg co $MC_COMMIT | ||
| cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be great to use bin/prepare-mochitests-dev
so that CI and contributors go through the same path.
But given this change, it looks like you had issue with keeping m-c clone around between two travis runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, caching was an issue.
update the travis setup:
drop circle mochitest support (will speed up the builds)