This repository was archived by the owner on Jan 11, 2023. It is now read-only.
3824 - ignore =, <, >, +, -, *, / tokens#3962
Merged
jasonLaster merged 1 commit intofirefox-devtools:masterfrom Sep 10, 2017
Merged
3824 - ignore =, <, >, +, -, *, / tokens#3962jasonLaster merged 1 commit intofirefox-devtools:masterfrom
jasonLaster merged 1 commit intofirefox-devtools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3962 +/- ##
=======================================
Coverage 55.68% 55.68%
=======================================
Files 128 128
Lines 4895 4895
Branches 1014 1014
=======================================
Hits 2726 2726
Misses 2169 2169
Continue to review full report at Codecov.
|
Contributor
Author
|
@jasonLaster Hi, how could I set a reviewer? I couldn't see a Reviewers option when/after creating PR. (the right side Reviewers section is unclickable but just plain test area)Thanks. |
Contributor
|
@Fischer-L happy to look. |
Contributor
|
Have you joined our slack? https://devtools-html-slack.herokuapp.com |
Contributor
Author
|
Thanks joined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3824
Summary of Changes
updatePreviewTest Plan
Screenshots/Videos
Please see [1] for the screenshots gif
[1] #3824 (comment)