This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix horizontal scrolling #3723
Merged
Fix horizontal scrolling #3723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@sagorika1996 why did you close this? |
Contributor
Author
|
@nyrosmith It was breaking for horizontal mode. It's fixed now. |
jasonLaster
approved these changes
Aug 19, 2017
Contributor
jasonLaster
left a comment
jasonLaster
left a comment
There was a problem hiding this comment.
I like where you're headed!
| { | ||
| className: "", | ||
| style: { | ||
| width: "100vw" |
Contributor
There was a problem hiding this comment.
lets move this to CSS.
Perhaps we should pass layout to CommandBar so that it can have a vertical, horizontal class?
jasonLaster
reviewed
Aug 19, 2017
| <div className="command-bar"> | ||
| <div | ||
| className="command-bar" | ||
| style={{ width: this.props.horizontal ? "100%" : "100vw" }} |
Contributor
There was a problem hiding this comment.
I like where this is headed. Is there a commandBar CSS file so we can do it w classes?
Codecov Report
@@ Coverage Diff @@
## master #3723 +/- ##
=======================================
Coverage 56.51% 56.51%
=======================================
Files 118 118
Lines 4636 4636
Branches 956 956
=======================================
Hits 2620 2620
Misses 2016 2016Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3719
Summary of Changes