This repository was archived by the owner on Jan 11, 2023. It is now read-only.
breakpoints disappear on sourcemapped sources#3440
Merged
jasonLaster merged 2 commits intofirefox-devtools:nextfrom Jul 25, 2017
Merged
Conversation
codehag
commented
Jul 25, 2017
|
|
||
| it("should render breakpoints with columns", async () => { | ||
| const sourceId = "server1.conn1.child1/source1"; | ||
| const breakpoints = I.Map({ id1: { location: { column: 2, sourceId } } }); |
Codecov Report
@@ Coverage Diff @@
## next #3440 +/- ##
=========================================
+ Coverage 49.8% 49.92% +0.12%
=========================================
Files 109 109
Lines 4516 4515 -1
Branches 930 929 -1
=========================================
+ Hits 2249 2254 +5
+ Misses 2267 2261 -6
Continue to review full report at Codecov.
|
jasonLaster
approved these changes
Jul 25, 2017
Contributor
jasonLaster
left a comment
jasonLaster
left a comment
There was a problem hiding this comment.
Thanks! I love the tests
| const breakpoints = I.Map({ id1: { location: { column: 2, sourceId } } }); | ||
|
|
||
| const { component, props } = render({ breakpoints }); | ||
| expect(component.find("Breakpoint").length).toBe(props.breakpoints.size); |
Contributor
There was a problem hiding this comment.
lets also have a snapshot here so we can get some regression testing on the children
| selectedSource: { sourceId, get: () => false }, | ||
| editor: { | ||
| codeMirror: { | ||
| setGutterMarker: jest.fn() |
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jul 26, 2017
* sourcemaps breakpoints disappear on sourcemapped sources * add snapshot
codehag
added a commit
to wldcordeiro/debugger.html
that referenced
this pull request
Jul 26, 2017
* sourcemaps breakpoints disappear on sourcemapped sources * add snapshot
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jul 27, 2017
* sourcemaps breakpoints disappear on sourcemapped sources * add snapshot
jbhoosreddy
pushed a commit
to jbhoosreddy/debugger.html
that referenced
this pull request
Aug 20, 2017
* sourcemaps breakpoints disappear on sourcemapped sources * add snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3439
When I started working on this issue, I wasn't sure what was wrong and it looked quite concerning, so i went ahead and started on it.
It looks like the error was coming from column breakpoints being ignored when column bps are enabled, and since all breakpoints which come from original sources have columns, these were being ignored. I removed the filter, as the breakpoints render correctly without it.
Caveat: Not sure if this is how it should work, or if column breakpoints are enabled by default.
I tested in a couple of spots:
TODO mvc: https://devtools-html.github.io/debugger-examples/examples/todomvc/
Sourcemapped files: http://wbamberg.github.io/example-websites/source-mapping/index.html
messy sourcemapped files: https://devtools-html.github.io/debugger-examples/examples/sequence-print/sequence_print.html
These three were also tested in the panel
I added a test to illustrate the case.
Summary of Changes
Test Plan
Add tests for both column and non column breakpoints. These were the bulk of the work, and are probably useful even if the fix isn't