Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Scroll onload#3431

Merged
jasonLaster merged 1 commit intofirefox-devtools:nextfrom
jasonLaster:scroll-onload
Jul 25, 2017
Merged

Scroll onload#3431
jasonLaster merged 1 commit intofirefox-devtools:nextfrom
jasonLaster:scroll-onload

Conversation

@jasonLaster
Copy link
Contributor

Associated Issue: #3411

Summary of Changes

  • fixes line scrolling by appropriately setting the pending jump line
  • we'll update the webconsole test when we make a new release

@codehag
Copy link
Contributor

codehag commented Jul 25, 2017

Thanks for picking this up! It isn't working for me when I follow the STR, what does your setup look like?

@codecov
Copy link

codecov bot commented Jul 25, 2017

Codecov Report

Merging #3431 into next will decrease coverage by 0.7%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##            next   #3431      +/-   ##
========================================
- Coverage   50.5%   49.8%   -0.71%     
========================================
  Files        109     109              
  Lines       4520    4518       -2     
  Branches     931     931              
========================================
- Hits        2283    2250      -33     
- Misses      2237    2268      +31
Impacted Files Coverage Δ
src/components/Editor/index.js 21.55% <0%> (-0.13%) ⬇️
src/actions/project-text-search.js 0% <0%> (-100%) ⬇️
src/reducers/project-text-search.js 31.57% <0%> (-68.43%) ⬇️
src/utils/search/project-search.js 94.73% <0%> (-5.27%) ⬇️
src/actions/sources.js 53.37% <0%> (-1.12%) ⬇️
src/actions/ast.js 78.57% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cac54...800534a. Read the comment docs.

@jasonLaster jasonLaster merged commit ffd8631 into firefox-devtools:next Jul 25, 2017
jasonLaster added a commit to jasonLaster/debugger.html that referenced this pull request Jul 26, 2017
jasonLaster added a commit to jasonLaster/debugger.html that referenced this pull request Jul 27, 2017
jbhoosreddy pushed a commit to jbhoosreddy/debugger.html that referenced this pull request Aug 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants