update: Adds support for recursive schema for python-sdk with model selection
#2266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chadha93
force-pushed
the
chadha93/py-recursion-fix
branch
from
3087745 to
944bbc3
Compare
|
Tested OK: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 issues found across 3 files
Prompt for AI agents (all 4 issues)
Understand the root cause of the following 4 issues and fix them.
<file name="apps/python-sdk/firecrawl/v2/utils/validation.py">
<violation number="1" location="apps/python-sdk/firecrawl/v2/utils/validation.py:5">
Importing WeakSet from typing raises an ImportError, so this module will fail to load until the import is removed or corrected.</violation>
<violation number="2" location="apps/python-sdk/firecrawl/v2/utils/validation.py:93">
Normalization skips list-valued schema nodes (anyOf/oneOf/items), so conflicting properties inside those arrays are never cleaned, breaking the intended OpenAI normalization for common recursive schemas.</violation>
<violation number="3" location="apps/python-sdk/firecrawl/v2/utils/validation.py:137">
Validation only descends into direct dict values and skips dicts inside arrays like anyOf/oneOf, allowing unsupported schema-less objects to slip through and fail later against OpenAI.</violation>
</file>
<file name="apps/python-sdk/firecrawl/v1/client.py">
<violation number="1" location="apps/python-sdk/firecrawl/v1/client.py:2869">
Removing additionalProperties for every object means callers who require additionalProperties: false lose that constraint, so extra fields slip through. Please only drop the flag when it is explicitly True to avoid regressing strict schemas.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
|
@cubic-dev-ai re-review |
@Chadha93 I've started the AI code review. It'll take a few minutes to complete. |
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="apps/python-sdk/firecrawl/v1/client.py">
<violation number="1" location="apps/python-sdk/firecrawl/v1/client.py:2862">
`$defs` entries never go through `_normalize_schema_for_openai`, so recursive definitions retain disallowed flags like `additionalProperties: true`, and recursive schemas remain incompatible with OpenAI.</violation>
</file>
<file name="apps/python-sdk/firecrawl/v2/utils/validation.py">
<violation number="1" location="apps/python-sdk/firecrawl/v2/utils/validation.py:59">
Returning as soon as $defs is present skips the additionalProperties/required cleanup for the current object, so recursive schemas still get sent to OpenAI with the incompatible flags and will be rejected.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
rebase Signed-off-by: Gaurav Chadha <chadha93@192.168.1.13>
Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Chadha93
force-pushed
the
chadha93/py-recursion-fix
branch
from
14e3802 to
825dcaf
Compare
Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>
|
@cubic-dev-ai re-review |
@Chadha93 I've started the AI code review. It'll take a few minutes to complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds recursive JSON schema support to the Python SDK with OpenAI-compatible normalization/validation and automatic model selection. Improves reliability for extract/jsonOptions when using $ref/$defs.