Force cookie toText to always output seven field regardless of maxAge…#7974
Open
dorfsmay wants to merge 1 commit intofirebug:masterfrom
dorfsmay:export_issue
Open
Force cookie toText to always output seven field regardless of maxAge…#7974dorfsmay wants to merge 1 commit intofirebug:masterfrom dorfsmay:export_issue
dorfsmay wants to merge 1 commit intofirebug:masterfrom
dorfsmay:export_issue
Conversation
… and expires values.0lll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export cookies is using cookie.toText, creating one line per cookie with either 6 or 7 tab separated field (or even 8 if you could set both maxAge and expires at the same time for a given cookie).
This PR forces the line to always be exactly 7 tab separated fields, using the assumption that expires has precedence on maxAge and that if neither is set than it is a session based cookie (see http://mrcoles.com/blog/cookies-max-age-vs-expires/).