Repository navigation
ListenerRegistration should implement IDisposable #746
Description
Please fill in the following fields:
Unity editor version: All
Firebase Unity SDK version: At least 6.15.2 and lower
Source you installed the SDK (.unitypackage or Unity Package Manager): UPM
Firebase plugins in use (Auth, Database, etc.): FireStore
Please describe the issue here:
Some 3rd party made to be general listener (honestly https://github.com/neuecc/UniRx)
I want to use FireStore Listener API with it but then ListenerRegistration need to implement IDisposable for compatible with it
Could you please add it like this
public sealed class ListenerRegistration : IDisposable
{
public Task ListenerTask { get; }
public void Stop();
public void Dispose() => listener.Stop();
}So I could use UniRX like so
Observable.Create<QuerySnapshot>((observer) => {
return colReference.Listen((snap) => observer.OnNext(snap));
});
Activity
google-oss-bot commentedon Aug 5, 2020
This issue does not seem to follow the issue template. Make sure you provide all the required information.
rafikhan commentedon Aug 5, 2020
Thanks for reporting this. We discussed this internally and plan to work on this in a future release.
b/162954556
Thaina commentedon May 25, 2021
@rafikhan Have this request made any progressed?
dconeybe commentedon May 25, 2021
Unfortunately, there is no update to share. For now, you can work around this by wrapping the
ListenerRegistrationobject returned fromListen()in a custom object that you create that implementsIDisposableand whoseDispose()method callslistener.Stop().Thaina commentedon May 25, 2021
@dconeybe That's what I have done so far and the point is I want to remove this pollution from my code
dconeybe commentedon May 25, 2021
Understood. I apologize for the delay and the obvious annoyance this is causing. I'll update this issue once the fix is ready for release which, unfortunately, I do not have any timeline for at this point.
Thaina commentedon Jun 16, 2021
@dconeybe This was already more than half a year for just 1 second to attach 2 lines of code. Even it cannot be released it should have been done and guarantee to available in the next version already without the need promising any timeline
dconeybe commentedon Jun 16, 2021
@Thaina I totally get your frustration. It is literally a 2-line fix and it seems ridiculous that it would take months to get fixed. The work has been prioritized but, since this bug has a workaround, it has not received attention yet. Unfortunately, I still can't make any statements about which version of the Unity SDK will contain the fix but I will post a comment to this bug once it's available.
dconeybe commentedon Jun 22, 2021
Update: The fix for this issue was submitted today by @ehsannas (cl/380662743 for Googlers). It will be included in the next Unity SDK release, planned to be version 8.1.0.
Thaina commentedon Jun 22, 2021
Thank you very much
dconeybe commentedon Jul 20, 2021
The fix has been included in yesterday's Unity SDK 8.1.0 release.
https://firebase.google.com/support/release-notes/unity#version_810_-_july_19_2021