Skip to content

fix(firestore, android): clean up Android transaction listeners on completion - #18475

Merged
SelaseKay merged 2 commits into
mainfrom
firestore_18474
Jul 23, 2026
Merged

fix(firestore, android): clean up Android transaction listeners on completion#18475
SelaseKay merged 2 commits into
mainfrom
firestore_18474

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

Fixes an Android memory leak in cloud_firestore transactions where native transaction state was retained after runTransaction completed.
Previously, each Android transaction registered transaction-specific state including an EventChannel, StreamHandler, transaction handler, and transaction reference, but that state was only cleared during full plugin cleanup. Apps that ran many transactions over time could therefore retain completed transaction resources indefinitely.
This change adds per-transaction cleanup when the transaction stream completes, removing the associated transaction, event channel, stream handler, and transaction result handler.

Related Issues

Fixes #18474

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay merged commit ae002c7 into main Jul 23, 2026
45 of 50 checks passed
@SelaseKay
SelaseKay deleted the firestore_18474 branch July 23, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants