fix(firestore, android): clean up Android transaction listeners on completion - #18475
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
…null transaction listeners
Description
Fixes an Android memory leak in
cloud_firestoretransactions where native transaction state was retained afterrunTransactioncompleted.Previously, each Android transaction registered transaction-specific state including an
EventChannel,StreamHandler, transaction handler, and transaction reference, but that state was only cleared during full plugin cleanup. Apps that ran many transactions over time could therefore retain completed transaction resources indefinitely.This change adds per-transaction cleanup when the transaction stream completes, removing the associated transaction, event channel, stream handler, and transaction result handler.
Related Issues
Fixes #18474
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?