feat(fdc): Happy Path Implementation - #18151
Merged
Merged
Conversation
Contributor
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
dconeybe
approved these changes
Mar 27, 2026
dconeybe
left a comment
dconeybe
left a comment
Contributor
There was a problem hiding this comment.
LGTM with some comments.
aashishpatil-g
changed the title
Contributor
Author
|
Failing tasks are not related to Data Connect package |
aashishpatil-g
added a commit
that referenced
this pull request
Mar 30, 2026
* Initial Commit * Fix formatting and analyzer warnings * Fix tests and licenses * Denver feedback: var initialization best practice * sorted keys for id generation * Fix analyze info messages
aashishpatil-g
added a commit
that referenced
this pull request
Apr 2, 2026
* Initial Commit * Fix formatting and analyzer warnings * Fix tests and licenses * Denver feedback: var initialization best practice * sorted keys for id generation * Fix analyze info messages
aashishpatil-g
added a commit
that referenced
this pull request
Apr 3, 2026
* Initial Commit * Fix formatting and analyzer warnings * Fix tests and licenses * Denver feedback: var initialization best practice * sorted keys for id generation * Fix analyze info messages
aashishpatil-g
added a commit
that referenced
this pull request
Apr 10, 2026
* Initial Commit * Fix formatting and analyzer warnings * Fix tests and licenses * Denver feedback: var initialization best practice * sorted keys for id generation * Fix analyze info messages
Lyokone
pushed a commit
that referenced
this pull request
Apr 13, 2026
* feat(fdc): Happy Path Implementation (#18151) * Initial Commit * Fix formatting and analyzer warnings * Fix tests and licenses * Denver feedback: var initialization best practice * sorted keys for id generation * Fix analyze info messages * feat(fdc): Handle disconnects and reconnects (#18157) * Handle disconnects and reconnects * Address gemini review comments * Reconnection logic * Fixes to reconnect on startup * Fix to decode binary data from server * Handle gemini feedback * Update rest_transport mocks with new windows provider sig * feat(fdc): Hardening (#18173) * debug logging and hardering * Hardening: ensure only one multicast stream controller is created in a ref * Handle cancellations * Formatting fix * Cynthia feedback (final, ...) * Gemini feedback: checkTransport single instancing. * Gemini feedback: cancel and nullify authSubscription in disconnect * Reverting authSubscription nullifying This affects reconnects. Taking tech debt instead. * Handle low priority gemini feedback * Gemini feedback: optimized operation id creation initialized as a lazy var that is used everywhere instead of computing always * Remove _queryId and use the computed operationId * Cynthia feedback on sending empty message to server * Remove grpc transport since its no longer used. * Update tests to incorporate operationId * Remove authToken appCheckToken fields. * Remove metadata file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inital implementation of happy path.