Skip to content

fix(functions): prevent collision when listening multiple times to the same stream#18052

Merged
Lyokone merged 1 commit intomainfrom
fix/18036
Mar 3, 2026
Merged

fix(functions): prevent collision when listening multiple times to the same stream#18052
Lyokone merged 1 commit intomainfrom
fix/18036

Conversation

@Lyokone
Copy link
Copy Markdown
Contributor

@Lyokone Lyokone commented Mar 3, 2026

Description

Fix stream collisions when calling HttpsCallable.stream concurrently on the same function.

The EventChannel name was derived solely from the function name, so parallel .stream() calls shared the same channel — causing data from one call to leak into another.

Each stream() invocation now gets a unique channel ID via a static counter.

Added E2E test that runs two concurrent .stream() calls with different input types on the same callable and verifies each stream receives only its own data.

Related Issues

Fixes #18036

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 3, 2026

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@Lyokone Lyokone merged commit c13040e into main Mar 3, 2026
32 of 33 checks passed
@Lyokone Lyokone deleted the fix/18036 branch March 3, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SelaseKay SelaseKay SelaseKay approved these changes

@MichaelVerdon MichaelVerdon MichaelVerdon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cloud_functions]: HttpsCallable.stream collisions occur when invoking the same function name simultaneously

3 participants

@Lyokone @SelaseKay @MichaelVerdon