feat(firebaseai): server prompt chat and function calling#17972
feat(firebaseai): server prompt chat and function calling#17972cynthiajoan wants to merge 15 commits intomainfrom
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces server-side template chat functionality with function calling capabilities to the Firebase AI example app. Key changes include adding FlutterFire configuration, refactoring function calling utilities into a dedicated file, and implementing various chat sessions and UI elements for different function calling scenarios (auto, client override, stream). The core library now includes new TemplateChatSession and TemplateTool related classes, and model request methods have been updated to support these new parameters. Review comments highlight critical null-safety issues in TemplateChatSession.sendMessage and sendMessageStream where _autoFunctions is used without proper null assertion, potentially leading to compile errors or runtime crashes. Additionally, a high-severity bug was found in _serverTemplateUrlContext in server_template_page.dart where a user message is added twice to the UI, causing duplication.
| final shouldAutoExecute = _autoFunctions!.isNotEmpty && | ||
| functionCalls.isNotEmpty && | ||
| functionCalls.every((c) => _autoFunctions.containsKey(c.name)); |
There was a problem hiding this comment.
This line can cause a crash and won't compile as intended.
_autoFunctions!will throw an exception if_autoFunctionsisnull. You should perform a null check first, like_autoFunctions != null._autoFunctions.containsKey(c.name)will cause a compile error because_autoFunctionsis a nullable type (Map?). You need to use the null-assertion operator (!) after the null check.
A safer implementation, consistent with sendMessageStream, would be:
final shouldAutoExecute = _autoFunctions != null &&
_autoFunctions.isNotEmpty &&
functionCalls.isNotEmpty &&
functionCalls.every((c) => _autoFunctions!.containsKey(c.name));| final shouldAutoExecute = _autoFunctions!.isNotEmpty && | |
| functionCalls.isNotEmpty && | |
| functionCalls.every((c) => _autoFunctions.containsKey(c.name)); | |
| final shouldAutoExecute = _autoFunctions != null && | |
| _autoFunctions.isNotEmpty && | |
| functionCalls.isNotEmpty && | |
| functionCalls.every((c) => _autoFunctions!.containsKey(c.name)); |
| final shouldAutoExecute = _autoFunctions != null && | ||
| _autoFunctions.isNotEmpty && | ||
| functionCalls.isNotEmpty && | ||
| functionCalls.every((c) => _autoFunctions.containsKey(c.name)); |
There was a problem hiding this comment.
This will cause a compile error because _autoFunctions is a nullable type (Map?), so you can't call containsKey on it directly. Since you've already checked that _autoFunctions is not null on line 183, you can safely use the null-assertion operator (!).
| functionCalls.every((c) => _autoFunctions.containsKey(c.name)); | |
| functionCalls.every((c) => _autoFunctions!.containsKey(c.name)); |
| await _handleServerTemplateMessage( | ||
| message, | ||
| (message) async { | ||
| _messages.add(MessageData(text: message, fromUser: true)); |
There was a problem hiding this comment.
The user's message is being added to the _messages list here, but it's also added inside the _handleServerTemplateMessage helper function (line 332). This will cause the user's message to be displayed twice in the UI. You should remove this line.
1 participant
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?