Skip to content

fix(app-check): token not available on new session#17872

Merged
SelaseKay merged 1 commit intofirebase:mainfrom
OutdatedGuy:fix/app-check-web
Dec 1, 2025
Merged

fix(app-check): token not available on new session#17872
SelaseKay merged 1 commit intofirebase:mainfrom
OutdatedGuy:fix/app-check-web

Conversation

@OutdatedGuy
Copy link
Copy Markdown
Contributor

@OutdatedGuy OutdatedGuy commented Nov 24, 2025

Description

Use localStorage to store app check details instead of sessionStorage so that the details are available when initializing app check before other plugins inside firebase_core in a new session (fresh new tab).

Related Issues

fixes #17611

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Nov 24, 2025

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@OutdatedGuy
Copy link
Copy Markdown
Contributor Author

OutdatedGuy commented Nov 24, 2025

Demo of the issue: https://auth-error-firebase.web.app

Demo of the fix: https://auth-error-fixed.web.app

Credentials:

Email: webauth@error.com
Password: 123456

@OutdatedGuy
Copy link
Copy Markdown
Contributor Author

OutdatedGuy commented Nov 26, 2025

Hi @MichaelVerdon @SelaseKay, can you look into this before the next release?

@SelaseKay
Copy link
Copy Markdown
Contributor

SelaseKay commented Nov 27, 2025

Hi @OutdatedGuy, thanks for the contribution. I've been able to test and can confirm that this PR resolves the linked issue. LGTM!

@MichaelVerdon
Copy link
Copy Markdown
Contributor

MichaelVerdon commented Nov 27, 2025

Hi @MichaelVerdon @SelaseKay, can you look into this before the next release?

Looks great to me thank you 😄

@OutdatedGuy
Copy link
Copy Markdown
Contributor Author

OutdatedGuy commented Nov 28, 2025

What's the ET for the next release?

@SelaseKay SelaseKay merged commit 702de52 into firebase:main Dec 1, 2025
22 of 28 checks passed
@SelaseKay SelaseKay mentioned this pull request Feb 10, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SelaseKay SelaseKay SelaseKay approved these changes

@MichaelVerdon MichaelVerdon MichaelVerdon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[firebase_auth_web] Session doesn't resume if firebase app check is configured

3 participants

@OutdatedGuy @SelaseKay @MichaelVerdon