fix(fdc): add support Int64 to nativeFromJson#17673
Merged
Lyokone merged 1 commit intofirebase:mainfrom Sep 12, 2025
Merged
Conversation
63c1afa to
1171660
Compare
Contributor
|
@slightfoot would you mind running the formatter and analyzer here? |
1171660 to
17176e5
Compare
Contributor
Author
|
@maneesht done |
maneesht
approved these changes
Sep 11, 2025
Lyokone
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you used a
Int64type in the GraphQL schema it cannot be decoded in the generated code.Int64is treated as aBigIntin Postgres/DataConnect and as such transmitted through gRPC as aString. Thefirebase_data_connectpackage throwsThis type is unimplemented: Type... because thenativeFromJsonfunction does not supportinputbeing aStringand the output type being anint.This PR also fixes the incorrect Type display in the error message for the exception.
@maneesht this one's for you.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?