fix(firebase_vertexai): add missing HarmBlockThreshold to exported APIs#17249
Merged
cynthiajoan merged 3 commits intofirebase:mainfrom Apr 4, 2025
rusudinu:add-missing-harm-block-method-to-exported-firebase-vertex
Merged
fix(firebase_vertexai): add missing HarmBlockThreshold to exported APIs#17249cynthiajoan merged 3 commits intofirebase:mainfrom rusudinu:add-missing-harm-block-method-to-exported-firebase-vertex
cynthiajoan merged 3 commits intofirebase:mainfrom
rusudinu:add-missing-harm-block-method-to-exported-firebase-vertex
Conversation
Contributor
Author
|
pushed another commit to remove the api.dart import for the chat_test and model_test |
MichaelVerdon
approved these changes
Apr 3, 2025
Contributor
MichaelVerdon
left a comment
There was a problem hiding this comment.
Looks good to me. Tried it out locally.
cynthiajoan
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The HarmBlockThreshold added in version 1.5.0 of firebase_vertexai is missing from the exported APIs. This PR adds it to the list.
This PR fixes the following scenario in which, I want to use HarmBlockMethod.probability like this:
SafetySetting(HarmCategory.hateSpeech, HarmBlockThreshold.high, HarmBlockMethod.probability),and being unable to only with the following import:
import 'package:firebase_vertexai/firebase_vertexai.dart';and I would need to also addimport 'package:firebase_vertexai/src/api.dart';which would be an anti-pattern.TLDR: HarmCategory and HarmBlockThreshold were already present, HarmBlockMethod was missing and this PR adds it to the exports list.
Related Issues
Fixes #17253
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?