feat(firestore): Swift Package Manager support#13329
Merged
russellwheatley merged 79 commits intomainfrom Nov 12, 2024
Merged
Conversation
Lyokone
approved these changes
Nov 4, 2024
Comment on lines
+9
to
+12
| await buildSwiftExampleApp('ios', 'firebase_core'); | ||
| await buildSwiftExampleApp('ios', 'cloud_firestore'); | ||
| await buildSwiftExampleApp('macos', 'firebase_core'); | ||
| await buildSwiftExampleApp('macos', 'cloud_firestore'); |
Contributor
There was a problem hiding this comment.
Will we need to do the other packages? Or is it just because cloud_firestore has its own SPM package?
Member
Author
There was a problem hiding this comment.
Yeah, it's just for the packages which have Swift support; core + firestore.
SelaseKay
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Package.swiftto negate duplicate symbols: https://github.com/firebase/flutterfire/pull/13329/files#diff-8ba779f9dea534ccdcb7bea8d78060e805ad75ef984ad7ce64d49c947ab76f16R111-R114Package.swiftfile. E.g: https://github.com/firebase/flutterfire/pull/13329/files#diff-8ba779f9dea534ccdcb7bea8d78060e805ad75ef984ad7ce64d49c947ab76f16R99melos version: https://github.com/firebase/flutterfire/blob/main/melos.yaml#L25git push --tags. Tag looks like3.6.0-firebase-core-swift. I would've like to use existing firebase core tag but it isn't semantically correct as Swift requires version first whilst our current tag looks likefirebase_core-v3.6.0(i.e. version last).generated_firebase_sdk_version.txtfile if the package has aPackage.swiftfile (i.e. supports Swift), it also ignore firebase_core plugin as it already has the canonicalfirebase_sdk_version.rbversion file.Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?