Skip to content

Commit ea1f309

Browse files
authored
fix(remote_config,windows): release mode wasn't linking properly for windows (#18073)
1 parent 80c6cff commit ea1f309

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/windows.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ jobs:
5353
- name: "Install Tools"
5454
run: |
5555
npm install -g firebase-tools
56+
- name: "Build Windows (Release)"
57+
run: cd tests && flutter build windows --release
5658
- name: Start Firebase Emulator and run tests
5759
run: cd ./.github/workflows/scripts && firebase emulators:exec --project flutterfire-e2e-tests "cd ../../../tests && flutter test .\integration_test\e2e_test.dart -d windows"
5860

packages/firebase_core/firebase_core/windows/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ add_subdirectory(${FIREBASE_CPP_SDK_DIR} bin/ EXCLUDE_FROM_ALL)
122122
target_include_directories(${PLUGIN_NAME} INTERFACE
123123
"${FIREBASE_CPP_SDK_DIR}/include")
124124

125-
set(FIREBASE_RELEASE_PATH_LIBS firebase_app firebase_auth firebase_storage firebase_firestore)
125+
set(FIREBASE_RELEASE_PATH_LIBS firebase_app firebase_auth firebase_remote_config firebase_storage firebase_firestore)
126126
foreach(firebase_lib IN ITEMS ${FIREBASE_RELEASE_PATH_LIBS})
127127
get_target_property(firebase_lib_path ${firebase_lib} IMPORTED_LOCATION)
128128
string(REPLACE "Debug" "Release" firebase_lib_release_path ${firebase_lib_path})

0 commit comments

Comments
 (0)