fix(auth, web): fix an issue that could occur when deleting FirebaseApp (#17145)

Lyokone · SelaseKay · web-flow · commit a2246cd0ae8a · 2025-02-26T13:23:50.000+01:00
* fix(auth, web): fix an issue that could occur when deleting FirebaseApp

* chore: add test for fix

* chore: move app name to variable

---------

Co-authored-by: Jude Kwashie &lt;judekwashie70@gmail.com&gt;
diff --git a/packages/firebase_auth/firebase_auth_web/lib/firebase_auth_web.dart b/packages/firebase_auth/firebase_auth_web/lib/firebase_auth_web.dart
@@ -202,8 +202,7 @@ class FirebaseAuthWeb extends FirebaseAuthPlatform {
   auth_interop.Auth? _webAuth;
 
   auth_interop.Auth get delegate {
-    _webAuth ??= auth_interop.getAuthInstance(core_interop.app(app.name));
-
+    _webAuth = auth_interop.getAuthInstance(core_interop.app(app.name));
     return _webAuth!;
   }
 
diff --git a/tests/integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart b/tests/integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart
@@ -840,6 +840,43 @@ void main() {
             fail(e.toString());
           }
         });
+        test(
+            'should not throw error when app is deleted and reinit with same app name',
+            () async {
+          try {
+            const appName = 'SecondaryApp';
+
+            final app = await Firebase.initializeApp(
+              name: appName,
+              options: DefaultFirebaseOptions.currentPlatform,
+            );
+
+            var auth1 = FirebaseAuth.instanceFor(app: app);
+
+            await auth1.signInWithEmailAndPassword(
+              email: testEmail,
+              password: testPassword,
+            );
+
+            await app.delete();
+
+            final app2 = await Firebase.initializeApp(
+              name: appName,
+              options: DefaultFirebaseOptions.currentPlatform,
+            );
+
+            final auth2 = FirebaseAuth.instanceFor(app: app2);
+
+            await auth2.signInWithEmailAndPassword(
+              email: testEmail,
+              password: testPassword,
+            );
+          } on FirebaseException catch (e) {
+            fail('Failed with error: $e');
+          } catch (e) {
+            fail(e.toString());
+          }
+        });
       });
 
       group('signOut()', () {

Original file line number	Diff line number	Diff line change
`@@ -202,8 +202,7 @@ class FirebaseAuthWeb extends FirebaseAuthPlatform {`
`202`	`202`	`auth_interop.Auth? _webAuth;`
`203`	`203`
`204`	`204`	`auth_interop.Auth get delegate {`
`205`		`- _webAuth ??= auth_interop.getAuthInstance(core_interop.app(app.name));`
`206`		`-`
	`205`	`+ _webAuth = auth_interop.getAuthInstance(core_interop.app(app.name));`
`207`	`206`	`return _webAuth!;`
`208`	`207`	`}`
`209`	`208`