handle null service account on CF deploy - #8381
Merged
Merged
Conversation
haggbart
approved these changes
Mar 27, 2025
haggbart
left a comment
haggbart
left a comment
There was a problem hiding this comment.
Nice!
Note: The changelog entry "Fix webframeworks deployments when deploying a SSR project" doesn't match this fix. Should be something like "Fix Cloud Functions deployment failure when service account is set to null"
MarioPreja
approved these changes
Mar 28, 2025
leoortizz
commented
Mar 28, 2025
leoortizz
changed the title
taeold
approved these changes
Mar 28, 2025
taeold
enabled auto-merge (squash)
March 28, 2025 18:06
blidd-google
pushed a commit
that referenced
this pull request
May 12, 2025
* handle null service account * changelog * use ternary instead * Update CHANGELOG.md * Fix bug for v1 and add test cases. --------- Co-authored-by: Daniel Young Lee <danielylee@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8378.
@taeold FWICT the change that caused the error was introduced in #8366
Before:
After:
Scenarios Tested
firebase deploywith a Next.js 15 appSample Commands
firebase deploy