Use FUNCTIONS_DISCOVERY_TIMEOUT when waiting for sockets - #7838
Conversation
Berlioz
left a comment
Berlioz
left a comment
There was a problem hiding this comment.
The change looks good, but IME stuff which affects timeouts has a nasty tendency to break the integration test suites. Some of these failures look like flakes, but the very long duration of some of the failures has me worried.
LGTM if you can either get a green build or fix the tsts.
Turns out these were actually catching a real bug in my code - I swapped a || for a ?? originally, which meant that when getFunctionDiscoveryTimeout returned a false but not undefined value, we'd set the timeout to 0 instead of the default value. Swapped it back and this seems to be good now |
2 participants
Description
Fixed an issue during functions discovery where
FUNCTIONS_DISCOVERY_TIMEOUTwasn't respected. Thanks @ErlikC for finding this fix!Fixes #6285.